fix(astro-engine): ensure clientDirectives is defined#220
Merged
Tate-CC merged 2 commits intoCloudCannon:mainfrom Jun 15, 2025
Merged
fix(astro-engine): ensure clientDirectives is defined#220Tate-CC merged 2 commits intoCloudCannon:mainfrom
Tate-CC merged 2 commits intoCloudCannon:mainfrom
Conversation
Tate-CC
requested changes
Jun 11, 2025
Contributor
Tate-CC
left a comment
Tate-CC
left a comment
There was a problem hiding this comment.
Thanks for the PR Oliver! I've just request one change. It looks like the clientDirectives object is used to validate the different kinds of directive you're allowed to use. So to support islands in bookshop components we need to include the full list of them (except for client:only which is special).
Co-authored-by: Tate-CC <63823334+Tate-CC@users.noreply.github.com>
Contributor
Author
|
Looks good to me! Tested the patch with one of my sites on cloudcannon and the live editor works again. I haven't tested if this affects server islands, as I don't have a site setup which uses those (yet?). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withastro/astro#13858 (Merged in Astro 5.8.1) breaks bookshop live as
validateComponentPropsnow expectsSSRResult.clientDirectivesto be defined, preventing rendering and causing the following warning in the editor: